Fix REJECTED error code to match the spec. #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should have been fixed in #151, that was an oversight from my part.
Member
Author
|
Thanks @yschimke for spotting this! |
xytosis
pushed a commit
to xytosis/reactivesocket-java
that referenced
this pull request
Aug 6, 2016
It should have been fixed in rsocket#151, that was an oversight from my part.
ilayaperumalg
pushed a commit
to ilayaperumalg/rsocket-java
that referenced
this pull request
Dec 26, 2017
Replace CONNECTION_ERROR_NO_RETRY with RESUME_REJECTED to be clearer. The REJECTED_RESUME frame mirrors the REJECTED_SETUP error. If SETUP fails, then REJECTED_SETUP. If RESUME fails, then REJECTED_RESUME. This was discussed in rsocket/rsocket#147
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should have been fixed in #151, that was an oversight from my part.